Skip to content

fix: add cmake subproject integration check#465

Open
feihongxu0824 wants to merge 1 commit into
alibaba:mainfrom
feihongxu0824:fix/cmake-subproject-integration-test
Open

fix: add cmake subproject integration check#465
feihongxu0824 wants to merge 1 commit into
alibaba:mainfrom
feihongxu0824:fix/cmake-subproject-integration-test

Conversation

@feihongxu0824
Copy link
Copy Markdown
Collaborator

Summary

  • Add a linux-x64 CMake subproject smoke check that configures zvec through an outer add_subdirectory() project.
  • Replace zvec-owned CMAKE_SOURCE_DIR path assumptions in DiskANN and FastPFOR with PROJECT_ROOT_DIR so the smoke check can pass from a standalone branch off main.

Note: the DiskANN path changes overlap with #464 because this branch is intentionally based directly on main; the new subproject check would fail on current main without those fixes.

Testing

  • ruby -e "require 'yaml'; YAML.load_file('.github/workflows/03-macos-linux-build.yml'); puts 'yaml ok'"
  • Attempted local CMake subproject configure on macOS arm64; it reached the external subproject path and then failed because sandboxed network prevented FastPFOR's ARM-only SIMDe FetchContent download. The CI check runs on linux-x64 and does not take that ARM download path.
  • Pre-commit hooks passed during commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant