Repository navigation
[geometry] Preserve rotation axis signs at exact half turns - #2191
Merged
servantftransperfect merged 1 commit intoOct 6, 2026
Merged
Conversation
cbentejac
force-pushed
the
fix-so3-half-turn-log
branch
from
October 5, 2026 14:38
5ea1018 to
5ee2894
Compare
servantftransperfect
approved these changes
Oct 6, 2026
servantftransperfect
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users working with synthetic relative poses can load a different rotation from pairs JSON for an exact symmetric half turn.
In a noise-free reproduction with
E = diag(0, 1, -1)and 12 fixed correspondences,estimateTransformStructureFromEssentialreturns an exact symmetric half-turn. Its JSON round trip changes two rotation entries from-1to+1before the fix. The fixed round trip preserves the rotation within1e-12.Features list
Implementation remarks
The near-pi branch selects the largest diagonal entry of the symmetric matrix instead of using antisymmetric differences, which vanish at an exact half turn.
The exact-half-turn test fails with the original header and passes with the fix. All 24 near-half-turn cases pass with both headers. Validation covers the five geometry test executables, which passed twice.