Repository navigation
ImageMatching: Only require featuresFolders when it is relevant to the matching method - #2197
Merged
Merged
Conversation
servantftransperfect
requested review from
CedricThebault,
cbentejac and
fabiencastan
October 9, 2026 06:46
servantftransperfect
force-pushed
the
dev/imageMatching
branch
from
October 9, 2026 06:49
69fdbf2 to
77cde9b
Compare
servantftransperfect
force-pushed
the
dev/imageMatching
branch
from
October 9, 2026 08:56
77cde9b to
aee5292
Compare
featuresFolders when it is relevant to the matching method
cbentejac
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Exhaustive and Sequential image matching methods do not read features or descriptors. They build image pairs only from the list of views. Even so, the
featuresFoldersparameter was always shown in the ImageMatching nodes, and thealiceVision_imageMatchingexecutable required it.This PR disables the parameter in Meshroom when it is not used, and makes it optional on the command line.
Changes
ImageMatching,ImageMatchingMultiSfM):featuresFoldersis now disabled whenmethodisExhaustiveorSequential.main_imageMatching.cpp:--featuresFoldersmoved from required to optional parameters. Meshroom does not pass disabled attributes on the command line, so leaving the option required would make these runs fail.Notes
featuresFolders.Sequentialmethod. In that node, onlyExhaustivedisables the parameter.