Skip to content

ImageMatching: Only require featuresFolders when it is relevant to the matching method - #2197

Merged
cbentejac merged 1 commit into
developfrom
dev/imageMatching
Oct 9, 2026
Merged

cbentejac merged 1 commit into
developfrom
dev/imageMatching

Conversation

@servantftransperfect

Copy link
Copy Markdown
Contributor

Description

The Exhaustive and Sequential image matching methods do not read features or descriptors. They build image pairs only from the list of views. Even so, the featuresFolders parameter was always shown in the ImageMatching nodes, and the aliceVision_imageMatching executable required it.

This PR disables the parameter in Meshroom when it is not used, and makes it optional on the command line.

Changes

  • Meshroom nodes (ImageMatching, ImageMatchingMultiSfM): featuresFolders is now disabled when method is Exhaustive or Sequential.
  • main_imageMatching.cpp:
    • --featuresFolders moved from required to optional parameters. Meshroom does not pass disabled attributes on the command line, so leaving the option required would make these runs fail.
    • When the selected method needs descriptors (any method other than Exhaustive and Sequential), the program checks that features folders were provided. If none were, it logs an error and exits with a failure code.

Notes

  • Behaviour is unchanged for the vocabulary tree, Frustum and Mirror methods. They still need featuresFolders.
  • ImageMatchingMultiSfM has no plain Sequential method. In that node, only Exhaustive disables the parameter.

@cbentejac cbentejac changed the title Do not requires featuresFolders for imageMatching when not needed by … ImageMatching: Only require featuresFolders when it is relevant to the matching method Oct 9, 2026
@cbentejac
cbentejac merged commit 59de23e into develop Oct 9, 2026
5 checks passed
@cbentejac
cbentejac deleted the dev/imageMatching branch October 9, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants