Skip to content

[cmake] Fix LAPACK/SuiteSparse never being built on Linux #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
predat wants to merge 5 commits into
base: develop
Choose a base branch
from
+21 −7
Open

[cmake] Fix LAPACK/SuiteSparse never being built on Linux #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
377cd73
fix(cmake): evaluate quoted conditions in av_conditional_option
predat Oct 9, 2026
42a5e30
fix(deps): pass BLAS/LAPACK paths as separate CMake arguments
predat Oct 9, 2026
9c976a5
fix(deps): build SuiteSparse without CUDA
predat Oct 9, 2026
8bfdcaf
build(deps): download GMP from the GNU mirror
predat Oct 9, 2026
f4650ce
fix(deps): tell SuiteSparse which BLAS the reference LAPACK provides
predat Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/cmake/ConditionalOption.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ function(av_conditional_option)
return()
endif()

# A condition given as a single quoted string (e.g. IF "A AND NOT B") arrives
# as one list element, which if() would treat as the name of a variable.
# Split it into separate arguments so that it is evaluated as an expression.
# Multi-element conditions are left untouched, so quoted values inside them
# (e.g. IF X STREQUAL "a b") keep their spaces.
list(LENGTH _co_IF _co_IF_LEN)
if(_co_IF_LEN EQUAL 1)
separate_arguments(_co_IF)
endif()
if(${_co_IF})
option(${_co_OPT_NAME} ${_opt_DESCRIPTION} ${_co_THEN})
else()
Expand Down
2 changes: 1 addition & 1 deletion src/cmake/DependenciesVersions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ set(DEP_LAPACK_URL "https://github.com/Reference-LAPACK/lapack/archive/v${DE
set(DEP_LAPACK_HASH "MD5=595b064fd448b161cd711fe346f498a7")

set(DEP_GMP_VERSION "6.2.1")
set(DEP_GMP_URL "https://gmplib.org/download/gmp/gmp-${DEP_GMP_VERSION}.tar.xz")
set(DEP_GMP_URL "https://ftp.gnu.org/gnu/gmp/gmp-${DEP_GMP_VERSION}.tar.xz")
set(DEP_GMP_HASH "MD5=0b82665c4a92fd2ade7440c13fcaa42b")

set(DEP_MPFR_VERSION "4.2.0")
Expand Down
3 changes: 2 additions & 1 deletion src/cmake/deps/lapack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ if(AV_BUILD_LAPACK)
${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/liblapack${CMAKE_SHARED_LIBRARY_SUFFIX}
)
set(LAPACK_CMAKE_FLAGS
"-DBLAS_LIBRARIES=${BLAS_LIBRARIES} -DLAPACK_LIBRARIES=${LAPACK_LIBRARIES}"
-DBLAS_LIBRARIES=${BLAS_LIBRARIES}
-DLAPACK_LIBRARIES=${LAPACK_LIBRARIES}
)

endif()
14 changes: 9 additions & 5 deletions src/cmake/deps/suitesparse.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# =============================================================================
# deps/suitesparse.cmake
# Dependencies: lapack (BLAS_LIBRARIES, LAPACK_LIBRARIES), cuda (optionnel)
# Dependencies: lapack (BLAS_LIBRARIES, LAPACK_LIBRARIES)
# Provides: SUITESPARSE_TARGET, SUITESPARSE_CMAKE_FLAGS
#
# NOTE: Requires gmp and mpfr as prerequisites, built inline here since they
Expand Down Expand Up @@ -85,9 +85,13 @@ if(AV_BUILD_SUITESPARSE)
# )
#endif()

if(AV_USE_CUDA)
set(_cuda_cmake_flags "-DENABLE_CUDA=ON\ -DCMAKE_CXX_FLAGS=-I${CUDA_TOOLKIT_ROOT_DIR}/include\ -DCMAKE_C_FLAGS=-I${CUDA_TOOLKIT_ROOT_DIR}/include")
set(_ss_lapack_flags ${LAPACK_CMAKE_FLAGS})
if(_ss_lapack_flags)
# SuiteSparse requires BLA_VENDOR along with BLAS_LIBRARIES; the reference BLAS is "Generic"
list(APPEND _ss_lapack_flags -DBLA_VENDOR=Generic)
endif()
# SuiteSparse's Makefile takes all CMake options in one space-separated variable
list(JOIN _ss_lapack_flags " " _ss_lapack_flags)

ExternalProject_Add(${SUITESPARSE_TARGET}
URL ${DEP_SUITESPARSE_URL}
Expand All @@ -104,7 +108,7 @@ if(AV_BUILD_SUITESPARSE)
CONFIGURE_COMMAND ""
BUILD_COMMAND
$(MAKE) -j${AV_BUILD_DEPENDENCIES_PARALLEL}
CMAKE_OPTIONS=${LAPACK_CMAKE_FLAGS}\ -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}\ -DCMAKE_INSTALL_LIBDIR=lib\ ${_cuda_cmake_flags}
CMAKE_OPTIONS=${_ss_lapack_flags}\ -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}\ -DCMAKE_INSTALL_LIBDIR=lib\ -DSUITESPARSE_USE_CUDA=OFF
INSTALL_COMMAND
$(MAKE) install
DEPENDS ${LAPACK_TARGET} mpfr
Expand All @@ -118,7 +122,7 @@ if(AV_BUILD_SUITESPARSE)

av_register_dep(${SUITESPARSE_TARGET})

unset(_cuda_cmake_flags)
unset(_ss_lapack_flags)
#unset(_ss_env)
#unset(_ss_blas)
#unset(_ss_cmake_opts)
Expand Down
Loading