Add ability to add props to script and noscript tags - #50
Open
rtrvrtg wants to merge 1 commit into
Open
Conversation
Author
|
Occurs to me that this might conflict with #46. Happy to go back and do another pass. |
|
I would appreciate this new feature very much. To ensure a good and save implementation of a new cookie consent manager in our website, I have to use text/plain type prop to the GTM implementation: Do you know when you will merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been using react-gtm for a while and we've hit the issue of the noscript iframe being visible on various platforms, thereby causing accessibility problems. We put this PR together to address this by allowing arbitrary attributes to be assigned to the
<noscript>tag, but figured we should do it to the<script>tag as well, to ensure we could do the same to it as well.Sorry about all the edits -- looks like my local prettier instance has made a lot of changes.