fix: remove circular useEffect deps in PreviewFrame and add toggle tests - #6
Merged
Merged
Conversation
- Replace useState(true) for isFirstLoad with useRef(true) in PreviewFrame so that tracking first-load state does not trigger re-renders or re-run the effect when updated - Remove `error` and `isFirstLoad` from the useEffect dependency array; both were being set *inside* the effect, creating unnecessary re-render cascades on every file system change - Remove the now-redundant early `setError(null)` guard (the success path already calls setError(null) at its end) - Add src/app/__tests__/main-content.test.tsx to verify the Preview/Code toggle buttons correctly switch views in both directions and multiple times Co-authored-by: Alin Epure <alinepuresv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
useState(true)forisFirstLoadwithuseRef(true)inPreviewFrameto avoid re-render cascadeserrorandisFirstLoadfrom theuseEffectdependency array; both were being set inside the effect, creating unnecessary re-render cycles on every file system changesrc/app/__tests__/main-content.test.tsxto verify Preview/Code switching works correctlyGenerated with Claude Code