Conversation
|
New monitoring version v3.19.9 tagged and included here, |
| ${GRPC_REVISION:+-DGRPC_ROOT="${GRPC_ROOT}"} \ | ||
| -DCMAKE_INSTALL_PREFIX=$INSTALLROOT \ | ||
| ${BOOST_REVISION:+-DBOOST_ROOT=$BOOST_ROOT} \ | ||
| ${LIBGRPC_REVISION:--DO2_MONITORING_CONTROL_ENABLE=0} \ |
There was a problem hiding this comment.
@singiamtel Can we disable SC2086 or make sure that it does not complain for certain kind of variables? ${LIBGRPC_REVISION:--DO2_MONITORING_CONTROL_ENABLE=0} will never expand to something with a space in it.
There was a problem hiding this comment.
It can only be disabled globally in the alidistlint config, or case by case with # shellcheck disable=SC2086 . What do you prefer?
If the problem is that it's annoying to quote them when unneeded, maybe the autofix thing helps.
There was a problem hiding this comment.
No, the issue is that we should not add quotes when not needed. I would vote for disabling SC2086 until it's possible to do whitelist "safe" variables.
| set MONITORING_ROOT \$::env(BASEDIR)/$PKGNAME/\$version | ||
| prepend-path ROOT_INCLUDE_PATH \$PKG_ROOT/include | ||
| EoF | ||
| alibuild-generate-module --bin --lib --root > etc/modulefiles/$PKGNAME |
There was a problem hiding this comment.
Same here $PKGNAME is guaranteed not to expand.
Avoid picking up incompatible protobuf from the system. Needs a new release of monitoring to be effective.
Follow-up to alisw/alidist#6034 (comment)
* Move to latest alibuild-recipe-tools * Cleanup monitoring recipe Avoid picking up incompatible protobuf from the system. Needs a new release of monitoring to be effective.
Follow-up to alisw/alidist#6034 (comment)
* Move to latest alibuild-recipe-tools * Cleanup monitoring recipe Avoid picking up incompatible protobuf from the system. Needs a new release of monitoring to be effective.
4 participants
Avoid picking up incompatible protobuf from the system. Needs a new release of
monitoring to be effective.