Repository navigation
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
🔎 Lint report:
|
| Rule | Count |
|---|---|
unsupported-operator |
9 |
invalid-argument-type |
4 |
unresolved-attribute |
2 |
unresolved-import |
1 |
First entries
tests/unit/commands/sql_review/test_projection_rule.py:22: [invalid-argument-type] invalid-argument-type: Argument is incorrect: Expected `SqlWorkloadEvidence`, found `None`
tests/unit/commands/test_doctor_versioning_checks.py:123: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["timed out"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:134: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["exited 42"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:276: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["status broke"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:353: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["yaml broke"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:589: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["yaml broke"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:377: [unresolved-attribute] unresolved-attribute: Attribute `mkdir` is not defined on `None` in union `Path | None`
tests/unit/commands/test_doctor_versioning_checks.py:401: [unresolved-attribute] unresolved-attribute: Attribute `mkdir` is not defined on `None` in union `Path | None`
tests/unit/commands/test_doctor_versioning_checks.py:383: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["orphan"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:413: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["git binary not available"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:496: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["permission denied"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:609: [unsupported-operator] unsupported-operator: Operator `in` is not supported between objects of type `Literal["no built profiles"]` and `str | None`
tests/unit/commands/test_doctor_versioning_checks.py:633: [invalid-argument-type] invalid-argument-type: Argument is incorrect: Expected `tuple[str, ...]`, found `list[Unknown]`
tests/unit/commands/test_doctor_versioning_checks.py:643: [invalid-argument-type] invalid-argument-type: Argument is incorrect: Expected `tuple[str, ...]`, found `list[Unknown]`
tests/unit/commands/test_doctor_versioning_checks.py:670: [invalid-argument-type] invalid-argument-type: Argument to `HTTPError.__init__` is incorrect: Expected `Message[str, str]`, found `None`
tests/unit/commands/test_source_picker.py:591: [unresolved-import] unresolved-import: Cannot resolve imported module `questionary`
✅ Fixed issues: none
Unchanged: 1260 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
- PR-Agent workflow with configurable OpenAI-compatible endpoint for automated code review on every PR - Lint diff workflow (ruff + ty advisory) posts incremental diagnostics as PR comments; ruff enforcement extracted from ci.yml into its own blocking job - uv.lock sync check blocks merge when lockfile drifts from pyproject.toml - Pull request template with type/checklist structure Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pin GitHub Actions to commit SHAs and run PR-Agent from pull_request_target without checking out PR code. Preserve duplicate lint diagnostics in lint_diff and cover the duplicate-count cases with tests. Add SPDX/provenance headers to generated grammar modules and tighten NOTICE to direct runtime dependencies.
Isolate HOME and XDG roots in the shared isolated_config fixture so doctor tests do not inspect developer global skill installs. Add a regression test that asserts global skill paths are rebased into the test sandbox.
Summary
Test plan
pytest tests/ -m 'not live'passes locally🤖 Generated with Claude Code