Add Kafka topic config reconciler for hermes-management and console - #2053
Merged
Conversation
✅ Benchmark comparison: PASSED
|
| config[TopicConfig.RETENTION_MS_CONFIG] = String.valueOf(topic.retentionTime.durationInMillis) | ||
| config[TopicConfig.UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG] = "false" | ||
| config[TopicConfig.MAX_MESSAGE_BYTES_CONFIG] = "1048576" | ||
| config |
michaldabrowski
approved these changes
Aug 6, 2026
WojciechSova
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds forward reconciliation of Kafka broker topic configuration against Hermes metadata, analogous to the existing ZooKeeper consistency tooling.
Detects and fixes drift of the Hermes-owned configs only (retention.ms, unclean.leader.election.enable, max.message.bytes) and can bootstrap topics missing on a cluster.
OwnedTopicConfigso what we write equals what we check.incrementalAlterConfigs(SET), so partitions, replication factor, and non-owned configs are never touched./consistency/kafka/..., all mutations default to dry-run (does not collide with existing orphan endpoints).Tests: JUnit/Spock unit tests, integration test (real Kafka), and co-located console specs. Docs updated in kafka-and-zookeeper.md.