Fix IForward definition#2457
Open
Kenzzer wants to merge 2 commits into
Open
Conversation
Member
Author
|
Disclaimer I have not tested the following changes, everything was done in the web editor. We desperately need a test suite for this sort of things. |
Member
|
I'm 80/20 convinced now is the right time to delete a ton of crap from the SP API. It's almost 20 years old and we should never have tied ICallable like this... we will need a new native signature to add anything.On May 12, 2026 2:10 AM, Benoist ***@***.***> wrote:Kenzzer left a comment (alliedmodders/sourcemod#2457)
Disclaimer I have not tested the following changes, everything was done in the web editor. We desperately need a test suite for this sort of things.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Member
|
As noted on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2456
This bug was known for a while (9th of April 2026), but unfortunately the lack of issue on the tracker made me forget how urgent it was.
https://discord.com/channels/335290997317697536/335290997317697536/1491812815860797532
This PR hopefully fixes vtable shift bugs with
IForwardforever. I have removed the inheritance ofICallablebyIForward, if any extension out there relied on the ability to mixIForward(s)withICallable(s)this is unfortunately permanently broken. However I am highly doubtful this is a feature that was desired by extensions.An alternative fix to this PR would be to have sourcepawn's
ICallablebe turned into a new classICallable2. I don't think I need to argue why this is a bad solution and avoided it.One more fix would be to find a method so that gcc,clang,msvc doesn't merge the vtable of
IForwardwithICallable. However even if that is possible, this won't help already compiled extensions. So this fix is a no go as well.