Statically link SourcePawn#2459
Merged
Merged
Conversation
dvander
force-pushed
the
static-link-sp
branch
2 times, most recently
from
b4daa9e to
7774ee6
Compare
This removes the SourcePawn shared library from the distrubtion, and statically links the VM to sourcemod.logic instead. This means we can stop designing public APIs that only SourceMod will ever use, since now SourceMod can just peek directly inside the VM. We still need a public API for extensions (and the "core" binary). But that API surface is a lot smaller than what the logic binary needs. Remove unused DebugReporter::GenerateCodeError function while we're here, since this will allow removing IPluginDebugInfo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the SourcePawn shared library from the distrubtion, and
statically links the VM to sourcemod.logic instead. This means we can
stop designing public APIs that only SourceMod will ever use, since now
SourceMod can just keep directly inside the VM.
We still need a public API for extensions (and the "core" binary). But
that API surface is a lot smaller than what the logic binary needs.