Fix #26 Issues with 'truncate-lines nil (Wrap at window edge)

[MLopez-Ibanez]

Fix #26 Issues with 'truncate-lines nil (Wrap at window edge)

[arximboldi]

I'm having trouble on GNU Emacs 25.1.1:

fci-mode: Wrong type argument: number-or-marker-p, nil

Full stack trace:

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  signal(wrong-type-argument (number-or-marker-p nil))
  fci-mode()
  eval((fci-mode) nil)
  eval-expression((fci-mode) nil)
  funcall-interactively(eval-expression (fci-mode) nil)
  #<subr call-interactively>(eval-expression record nil)
  ad-Advice-call-interactively(#<subr call-interactively> eval-expression record nil)
  apply(ad-Advice-call-interactively #<subr call-interactively> (eval-expression record nil))
  call-interactively(eval-expression record nil)
  command-execute(eval-expression record)
  execute-extended-command(nil "eval-expression")
  smex-read-and-run(("fci-mode" "package-delete" "package-install" "customize-group" "list-packages" "revert-buffer" "rename-current-file-or-buffer" "rgrep" "string-rectangle" "customize-variable" "desktop-clear" "describe-function" "vc-diff" "sort-lines" "describe-variable" "kill-rectangle" "load-theme" "customize-face" "grep" "comment-region" "vc-revert-buffer" "compile-at" "customize-themes" "magit-status" "set-variable" "delete-file" "uncomment-region" "irony-get-type" "gdb" "c++-mode" "gdb-file" "shell-toggle" "irony-cdb-menu" "irony-cdb-autosetup-compile-options" "describe-key" "term" "chmod" "magit-blame" "flycheck-mode" "cljsbuild-start" "describe-package" "c-set-style" "cmake-ide-run-cmake" "magit-run-git-gui-blame" "irony-mode" "vc-git-grep" "dumb-jump-go" "cider-connect" "toggle-truncate-lines" "magit-diff" ...))
  smex()
  funcall-interactively(smex)
  #<subr call-interactively>(smex nil nil)
  ad-Advice-call-interactively(#<subr call-interactively> smex nil nil)
  apply(ad-Advice-call-interactively #<subr call-interactively> (smex nil nil))
  call-interactively(smex nil nil)
  command-execute(smex)
  recursive-edit()
  debug()
  funcall-interactively(debug)
  #<subr call-interactively>(debug record nil)
  ad-Advice-call-interactively(#<subr call-interactively> debug record nil)
  apply(ad-Advice-call-interactively #<subr call-interactively> (debug record nil))
  call-interactively(debug record nil)
  command-execute(debug record)
  execute-extended-command(nil "debug")
  smex-read-and-run(("fci-mode" "package-delete" "package-install" "customize-group" "list-packages" "revert-buffer" "rename-current-file-or-buffer" "rgrep" "string-rectangle" "customize-variable" "desktop-clear" "describe-function" "vc-diff" "sort-lines" "describe-variable" "kill-rectangle" "load-theme" "customize-face" "grep" "comment-region" "vc-revert-buffer" "compile-at" "customize-themes" "magit-status" "set-variable" "delete-file" "uncomment-region" "irony-get-type" "gdb" "c++-mode" "gdb-file" "shell-toggle" "irony-cdb-menu" "irony-cdb-autosetup-compile-options" "describe-key" "term" "chmod" "magit-blame" "flycheck-mode" "cljsbuild-start" "describe-package" "c-set-style" "cmake-ide-run-cmake" "magit-run-git-gui-blame" "irony-mode" "vc-git-grep" "dumb-jump-go" "cider-connect" "toggle-truncate-lines" "magit-diff" ...))
  smex()
  funcall-interactively(smex)
  #<subr call-interactively>(smex nil nil)
  ad-Advice-call-interactively(#<subr call-interactively> smex nil nil)
  apply(ad-Advice-call-interactively #<subr call-interactively> (smex nil nil))
  call-interactively(smex nil nil)
  command-execute(smex)

[alpaker]

Try applying this change?

diff --git a/fill-column-indicator.el b/fill-column-indicator.el
index b6e4b60..4d865e6 100644
--- a/fill-column-indicator.el
+++ b/fill-column-indicator.el
@@ -782,7 +782,7 @@ rough heuristic.)"
         (goto-char end)
         (setq end (line-beginning-position 2))
         (fci-delete-overlays-region-win start end win)
-        (if (> (window-width win) fci-rule-column)
+        (if (> (window-width win) fci-column)
             (fci-put-overlays-region start end win))))))

 (defun fci-redraw-region (start end _ignored)
@@ -793,7 +793,7 @@ rough heuristic.)"
         (goto-char end)
         (setq end (line-beginning-position 2))
         (fci-delete-overlays-region-win start end (selected-window))
-        (if (> (window-width (selected-window)) fci-rule-column)
+        (if (> (window-width (selected-window)) fci-column)
             (fci-put-overlays-region start end (selected-window)))))))

 (defun fci-redraw-window (win &optional start)```

[aspiers]

I've resolved this conflict and pushed here:

master...aspiers:wrap-window-edge

However I have no idea if it's the right approach. It still doesn't work well for me.