Repository navigation
fix(feed): clear action bar subtitle on fragment stop (#13366) - #2
Merged
Merged
Conversation
ngan-giang-phan
requested changes
Oct 29, 2026
| */ | ||
| override fun onStop() { | ||
| super.onStop() | ||
| // Unconditionally clear the subtitle so it doesn't leak into other fragments |
Collaborator
There was a problem hiding this comment.
This fixes the leak onto channel page, but the group name now goes missing from the group’s own feed. Probably because this clears the subtitle every time any feed goes out of frame.
Maybe add a conditional clear (only if the subtitle belongs to this feed) and also restore the name in onResume()
pr_review_alysha.webm
Owner
Author
There was a problem hiding this comment.
Thanks for catching that. I've updated FeedFragment.kt to restore the subtitle in onResume() so it stays on the group's feed, while still clearing it in onStop() to prevent leaking.
Tested in on my device and it works as expected now. Could you take another quick look?
update.mp4
ngan-giang-phan
approved these changes
Oct 30, 2026
ngan-giang-phan
left a comment
ngan-giang-phan
left a comment
Collaborator
There was a problem hiding this comment.
Everything seems fine to me
Owner
Author
|
Opened upstream as TeamNewPipe#13974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
onResume()inFeedFragment.ktto restore thegroupNamesubtitle when returning to the feed tab.onStop()to safely clear the action bar subtitle if it matchesgroupName, preventing it from leaking into subsequent views when navigating away.Before/After Screen Record
before.mp4
after.mp4
Fixes the following issue(s)
Testing/QA
Devices
Steps for testing
APK for testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence