Update readme with missing feature flag.#289
Open
nicolas-sabbatini wants to merge 1 commit intoamethyst:masterfrom
Open
Update readme with missing feature flag.#289nicolas-sabbatini wants to merge 1 commit intoamethyst:masterfrom
nicolas-sabbatini wants to merge 1 commit intoamethyst:masterfrom
Conversation
The readme file is missing the codegen feature flag.
Author
|
I believe that the last 4 point of the checklist don't apply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme file is missing the codegen feature flag.
Description
I just added the missing feature flag.
Motivation and Context
If you read the readme and tray to use the lib in a wasm project, the build is going to fail, and you are not going to know why.
How Has This Been Tested?
It displays correctly in the GitHub README.
Checklist: