Skip to content

feat: Performance boost with Promise.all concurrency 馃殌 #40212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjaiyan-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Performance boost with Promise.all concurrency 馃殌 #40212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7483440
perf: Improve performance by running async tasks concurrently
sanjaiyan-dev Dec 26, 2024
b6b250e
build: Refactor buildWebPushPublisherFiles for improved readability
sanjaiyan-dev Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions build-system/tasks/dist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,19 @@ function buildLoginDone(version) {
async function buildWebPushPublisherFiles() {
const distDir = 'dist/v0';
for (const version of WEB_PUSH_PUBLISHER_VERSIONS) {
for (const fileName of WEB_PUSH_PUBLISHER_FILES) {
const tempBuildDir = `build/all/amp-web-push-${version}`;
const builtName = `${fileName}.js`;
const minifiedName = maybeToEsmName(builtName);
await compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, {
watch: argv.watch,
includePolyfills: true,
minify: true,
minifiedName,
});
}
await Promise.all(
WEB_PUSH_PUBLISHER_FILES.map((fileName) => {
const tempBuildDir = `build/all/amp-web-push-${version}`;
const builtName = `${fileName}.js`;
const minifiedName = maybeToEsmName(builtName);
return compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, {
watch: argv.watch,
includePolyfills: true,
minify: true,
minifiedName,
});
})
);
}
await postBuildWebPushPublisherFilesVersion();
}
Expand Down Expand Up @@ -284,8 +286,10 @@ async function postBuildWebPushPublisherFilesVersion() {
}

// Build Helper Frame HTML
const html = await fs.readFile(`${basePath}/${fileName}.html`, 'utf8');
const js = await fs.readFile(minifiedFile, 'utf8');
const [html, js] = await Promise.all([
fs.readFile(`${basePath}/${fileName}.html`, 'utf8'),
fs.readFile(minifiedFile, 'utf8'),
]);
const minifiedHtml = html.replace(
`<!-- [REPLACE-SENTINEL ${fileName}.js] -->`,
`<script>${js}</script>`
Expand Down
Loading