🐛 Fix: Clickio amp-ad vendor: enhanced Page URL Handling for Cached AMP Pages - #40392
Closed
ClickioTech wants to merge 6 commits into
Closed
ClickioTech wants to merge 6 commits into
ClickioTech wants to merge 6 commits into
Conversation
…ng code formatting. Removed unused import and adjusted spacing for better readability.
- Added support for retrieving the page URL from `global.context.sourceUrl` - Introduced `clickioGlobal.ampContext` to store the global context for improved access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
On cached AMP pages, the Clickio ad unit was sending incorrect URLs. The issue occurred because the ad was using
global.context.location.hrefwhich returns the cached URL instead of the original canonical URL.Root Cause
global.context.location.hrefwhich points to the cached URLChanges Made
global.context.sourceUrlfirst, falling back toglobal.context.location.hrefif not availableclickioGlobal.ampContext = global.contextfor better access to the global context