Skip to content

BUG: Long namespace/service names break up thing in many places #25

Description

@Hi-Fi

There has been quite many times, when Kolga's way of generating names has hit severely to deployment, one e.g. https://github.com/City-of-Helsinki/yjdh/runs/4837858868?check_suite_focus=true:

Error: rendered manifests contain a resource that already exists. Unable to continue with install: NetworkPolicy "hl-365-automated-message-when-application-reopened-y-net-policy" in namespace "yjdh-hl-365-automated-message-when-application-reopened-638" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "hl-365-automated-message-when--review-yjdh-bf-bknd": current value is "hl-365-automated-message-when--review-yjdh-bf-appl"

Max length of all possible generated name parts should be determined, and e.g. hashed to be short enough. Now it seems that name lenght comes back quite often.

E.g. https://github.com/City-of-Helsinki/review-services-action/blob/main/src/utils.ts#L7-L20 has of course easier job as there's only one name to generate, but in Kolga's case it would be enough to take the "worst" case. Usually namespace tells the deployment/app, so pod doesn't necessarily have to repeat that.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions