Enable riscv64 for most samples. #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanAlbert
commented
Aug 15, 2025
enh-google
reviewed
Aug 18, 2025
...logic/src/main/java/com/android/ndk/samples/buildlogic/AndroidApplicationConventionPlugin.kt
Show resolved
Hide resolved
enh-google
reviewed
Aug 18, 2025
enh-google
reviewed
Aug 18, 2025
enh-google
reviewed
Aug 18, 2025
enh-google
reviewed
Aug 18, 2025
enh-google
approved these changes
Aug 18, 2025
DanAlbert
force-pushed
the
rv64
branch
3 times, most recently
from
fca0678 to
d9a9358
Compare
enh-google
approved these changes
Aug 18, 2025
This isn't a supported ABI yet, but I want to enable it here to get ahead of some of that work. I just disabled that config for any of the samples which don't already work with rv64. There are a few reasons why some samples don't work with rv64 yet, noted in the comments next to the line that disables the ABI. Most of them are because some upstream dependency doesn't yet include rv64 libraries, and there's nothing we can do about that here. I haven't actually tested that any of these run because I don't have the hardware to do so.
enh-google
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a supported ABI yet, but I want to enable it here to get ahead of some of that work. I just disabled that config for any of the samples which don't already work with rv64. There are a few reasons why some samples don't work with rv64 yet, noted in the comments next to the line that disables the ABI. Most of them are because some upstream dependency doesn't yet include rv64 libraries, and there's nothing we can do about that here.