Add R3.CompositeDisposable support to AddTo extension#277
Open
YoruYomix wants to merge 1 commit intoannulusgames:mainfrom
Open
Add R3.CompositeDisposable support to AddTo extension#277YoruYomix wants to merge 1 commit intoannulusgames:mainfrom
YoruYomix wants to merge 1 commit intoannulusgames:mainfrom
Conversation
Member
|
Wouldn't |
Author
|
It works in simple cases, but breaks down when you need to chain further after AddTo. A common real-world pattern is: await LMotion.Create(0f, _originalColor.a, _duration)
.WithEase(Ease.OutSine)
.BindToColorA(_image)
.AddTo(compositeDisposable)
.ToUniTask(cancellationToken);Without this overload, the chain must be split into separate statements because ToDisposable() loses the MotionHandle, making .ToUniTask() unreachable: var handle = LMotion.Create(0f, _originalColor.a, _duration)
.WithEase(Ease.OutSine)
.BindToColorA(_image);
handle.ToDisposable().AddTo(compositeDisposable)
await handle.ToUniTask(cancellationToken);Since AddTo(CompositeDisposable) returns this (MotionHandle), the chain stays intact — ToDisposable() breaks it by converting to IDisposable early. So while the workaround is functional, it forces boilerplate that the overload cleanly eliminates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AddTo(R3.CompositeDisposable) overload for MotionHandle.
This allows motion handles to be added to R3's CompositeDisposable,
which automatically cancels the motion when disposed.