refactor: introduce SubResource/SubResourceList abstractions#183
Open
Xiol wants to merge 1 commit into
Open
Conversation
Add generic SubResource[T, ParentID, ChildID] and SubResourceList[T, ParentID] types to pkg/service/internal/resource/ to eliminate repeated sub-resource boilerplate across all services. Constructors: - NewStringSubResourceList / NewIntSubResourceList (validated) - NewUncheckedStringSubResourceList (no validation, for firewall rule ports, network rule ports, affinity rule members, network NICs) - NewStringIntSubResource / NewIntIntSubResource / NewStringStringSubResource Methods: List, ListPaginated, Get, Create, Update (PUT), Patch (PATCH→error), PatchReturning (PATCH→T), Delete Services migrated (public interfaces unchanged): - safedns: zone records, zone notes, template records - ddosx: domain records, properties, WAF rule sets/rules/advanced rules, ACL GeoIP/IP rules, CDN rules, HSTS rules - loadbalancer: listener certs/binds/access-IPs/ACLs, targetgroup targets/ACLs - ecloud: vpc/instance/firewallpolicy/firewallrule/networkpolicy/networkrule/ router/vpngateway/vpnsession/affinityrulemember/volume/image/ availabilityzone/host/hostgroup/network/nic/floatingip/volumegroup/ vpnendpoint/vpngatewayspecs/vpnservice/dhcp sub-resources - pss: request replies/conversation - draas: solution backup resources/failover plans/compute resources/hardware plans Also adds subresource_test.go covering all CRUD operations. All 21 test packages continue to pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Xiol
force-pushed
the
refactor/sub-resource-abstractions
branch
from
2a45c89 to
98fd341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generic SubResource[T, ParentID, ChildID] and SubResourceList[T, ParentID] types to pkg/service/internal/resource/ to eliminate repeated sub-resource boilerplate across all services.
Constructors:
Methods: List, ListPaginated, Get, Create, Update (PUT), Patch (PATCH→error), PatchReturning (PATCH→T), Delete
Services migrated (public interfaces unchanged):
Also adds subresource_test.go covering all CRUD operations.
All 21 test packages continue to pass.