fix(plugin-dev): assert expected hook decision - #83992
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Add an optional --expect flag so hook tests fail when the observed allow, deny, or ask decision does not match the intended outcome.\n\nRefs anthropics#83800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #83800.
test-hook.shcurrently treats both allow and deny outcomes as successful execution. That verifies that a hook ran, but it cannot catch a hook that allows an operation it was intended to deny.This change adds an optional
--expect allow|deny|askflag. When provided, the tester derives the observed decision from structuredhookSpecificOutput.permissionDecision, falling back to the hook exit code, and fails if the result does not match.Calls that do not use
--expectretain the existing behavior.Changes
--expect/-eoption.Verification
--expect allowwith an allowing hook: passes.--expect denywith an allowing hook: fails with status 1.--expect denywith an exit-2 hook: passes.--expect askwith structured JSON output: passes.bash -n plugins/plugin-dev/skills/hook-development/scripts/test-hook.shgit diff --checkScope
This PR only adds optional result assertions. It does not change hook matching, hook execution, or the legacy success criteria when no expected decision is supplied.