fix(scripts): reject self-referential duplicates - #83993
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Prevent the duplicate-comment workflow from proposing the triggering issue as its own duplicate, which could otherwise feed a self-reference into automatic closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
comment-on-duplicates.shfrom proposing the triggering issue as a duplicate of itself.The script previously accepted identical base and duplicate issue numbers, posted a self-referential duplicate comment, and returned success. That comment could then be consumed by the automatic duplicate closer.
Changes
BASE_ISSUE.Verification
BASE_ISSUE=123and duplicate123: the script posted the comment and exited 0.#123cannot duplicate itself, exits 1, and makes noghcalls.123 -> 456case still validates both issues and posts the expected comment.bash -n scripts/comment-on-duplicates.sh.git diff --check.Scope
This PR only rejects self-references. It does not change duplicate ranking, comment wording, or automatic-close timing.