fix(scripts): validate label option values - #83995
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Report missing --add-label and --remove-label values explicitly instead of aborting through set -u with an unbound positional parameter.
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate that
--add-labeland--remove-labeleach receive a label name before reading the next positional argument.With
set -u, invoking either option without a value previously aborted with an internal$2: unbound variableerror. A following option could also be consumed as the missing value before failing later.Changes
--add-labelhas no value.--remove-labelhas no value.Verification
--add-labelwithout a value: exits 1 with a specific error and no unbound-variable message.--remove-labelwithout a value: exits 1 with a specific error and no unbound-variable message.--add-label --remove-label bug: fails at--add-labelinstead of consuming the next option.gh issue editwith both operations.bash -n scripts/edit-issue-labels.sh.git diff --check.Scope
This PR only validates option values. It does not change label existence filtering or GitHub API behavior.