fix(plugin-dev): handle wrapped hook schemas and optional matchers in validate-hook-schema.sh - #84381
Open
erichanwang wants to merge 1 commit into
Open
fix(plugin-dev): handle wrapped hook schemas and optional matchers in validate-hook-schema.sh#84381erichanwang wants to merge 1 commit into
erichanwang wants to merge 1 commit into
Conversation
… validate-hook-schema.sh
jayesh-keychain
approved these changes
Aug 6, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
validate-hook-schema.shscript inplugins/plugin-devso it accurately validates Claude Code hook configurations (hooks.json).Changes
hooksKey: Detects whether hook handlers are defined under a top-level"hooks"object wrapper (e.g.{"description": "...", "hooks": {"SessionStart": [...]}}) or flat at the root level.description,$schema,title,version) when iterating hook event names.matcherOptional: Removed mandatorymatchercheck since matchers are optional in Claude Code hooks (matching all events by default when omitted).Verification
Validated against all 5 plugin
hooks.jsonfiles in the repo (explanatory-output-style,security-guidance,learning-output-style,hookify,ralph-wiggum). All 5 now pass validation (✅ All checks passed!).