Enhancements of the redis-rb-cluster - #6
Conversation
|
Hi @antirez , will you spend some time on reviewing this PR? Thanks a lot.. |
|
Hello, sorry I have missed this. Sounds interesting! Please could you return the indentation to 4 spaces? This is a matter of tastes and since the project was organized this way it is outside the context of making it better to adapt it to other coding styles ;-) But overall, this is promising and I waited for some improvements, so thanks! |
|
@antirez :) I actually prefer 4 spaces since I am from Python world. Sure, will do it soon. |
|
@antirez 4 spaces now. :) |
|
Hello, will this be merged soon? I would like to see the changes iandyh made. |
There was a problem hiding this comment.
Is this a copy of redis-trib.rb from https://github.com/antirez/redis/blob/unstable/src/redis-trib.rb ?
There was a problem hiding this comment.
Yes. But this is only for local development.
|
@jerryluk Hi! I'd suggest you test this branch in your environment and report any issues back to me. |
|
Hi, |
These are the main enhancements:
And some other subtle improvements.
Most of the data structure commands are implemented. However, there are still some missing commands, e.g.
pubsuband cluster related specific commands.And the last, what license of this client will be?
This is quite a big PR, thanks!