Skip to content

Enhancements of the redis-rb-cluster - #6

Open
iandyh wants to merge 73 commits into
antirez:masterfrom
iandyh:read-slave
Open

Enhancements of the redis-rb-cluster#6
iandyh wants to merge 73 commits into
antirez:masterfrom
iandyh:read-slave

Conversation

@iandyh

@iandyh iandyh commented Oct 19, 2015

Copy link
Copy Markdown

These are the main enhancements:

  1. Each redis node has a connection pool(fork safe)
  2. Can enable to read from slave
  3. Each redis command has a corresponding ruby method
  4. Unit tests cover all the commands
  5. Change indention from 4 to 2....

And some other subtle improvements.

Most of the data structure commands are implemented. However, there are still some missing commands, e.g. pubsub and cluster related specific commands.

And the last, what license of this client will be?

This is quite a big PR, thanks!

@iandyh

iandyh commented Oct 29, 2015

Copy link
Copy Markdown
Author

Hi @antirez , will you spend some time on reviewing this PR? Thanks a lot..

@antirez

antirez commented Oct 29, 2015

Copy link
Copy Markdown
Owner

Hello, sorry I have missed this. Sounds interesting! Please could you return the indentation to 4 spaces? This is a matter of tastes and since the project was organized this way it is outside the context of making it better to adapt it to other coding styles ;-) But overall, this is promising and I waited for some improvements, so thanks!

@iandyh

iandyh commented Oct 29, 2015

Copy link
Copy Markdown
Author

@antirez :) I actually prefer 4 spaces since I am from Python world. Sure, will do it soon.

@iandyh

iandyh commented Oct 30, 2015

Copy link
Copy Markdown
Author

@antirez 4 spaces now. :)

@dsklopp

dsklopp commented Nov 17, 2015

Copy link
Copy Markdown

Hello, will this be merged soon? I would like to see the changes iandyh made.

Comment thread dev/redis-trib.rb

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But this is only for local development.

@jerryluk

Copy link
Copy Markdown

@antirez Do you think with this PR, this gem would be production ready? We have been waiting long for a stable Ruby client for Redis cluster and I am glad @landyh is able to help.

Thank you for providing such great gem!

@iandyh

iandyh commented May 30, 2016

Copy link
Copy Markdown
Author

@jerryluk Hi! I'd suggest you test this branch in your environment and report any issues back to me.

@mPanasiewicz

Copy link
Copy Markdown

Hi,
Will you merge this PR. IS it ok for production enviroment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants