Add default sound to iOS push payload - #107
Merged
Merged
Conversation
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
cheggaaa
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildFcmIosMessagesets onlymutable-content: 1, and the Firebase Admin SDK omits thesoundkey entirely whenAps.Soundis empty — so the delivered notification hascontent.sound == niland iOS plays nothing.body,userInfoandbadgebut neversound, and iOS has no per-app sound default to fall back on. Android is unaffected because it receives a data-only message and builds the notification itself, where the NotificationChannel supplies the sound.Payload before/after, verified against the Firebase SDK marshaller:
buildFcmIosSilentMessageis intentionally untouched — that is theNotifyReadbackground push used to dismiss delivered notifications on other devices, and it must stay content-available only.