fix(auth): restore session token after renderer reload - #2337
Open
cjthevillain wants to merge 1 commit into
Open
cjthevillain wants to merge 1 commit into
cjthevillain wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
cjthevillain
marked this pull request as ready for review
August 16, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTabso a renderer reload can resume the existing sessionRoot cause
AuthStore.tokenSet()sends the session token throughupdateTab. The main process merged that update intoview.data, whilegetTabreturned only{ id, data }. The renderer expectstab.token, so afterCtrl+Rit could not find the live token and unnecessarily fell back to the OS keychain/recovery flow.This was reproduced on CachyOS with Anytype 0.56.1. Windows was not tested.
Validation
bun run test -- src/ts/lib/web/electronMock.test.tsbun run typecheckbun run lintbun run build:electronThe full local test command still reports unrelated existing test-harness failures where auto-imported globals such as
UandRelationare unavailable; the new regression test passes independently.