Repository navigation
Add Kubernetes-recommended labels to Helm chart - #71987
mihirduvedi wants to merge 5 commits into
Conversation
Miretpl
left a comment
There was a problem hiding this comment.
With using recommended k8s labels, we could delete old once (we are on chart 2.0 on main) and leave only necessery onces. We don't need to have all of these labels with duplicated values when there is Kubernetes standard for them.
7e562ae to
90b904b
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
8ba205c to
62a704e
Compare
|
Refreshed this PR against current The fork CI run passed all 2,280 Helm tests across nine groups with Kubernetes 1.31.12, Helm release checks, static checks, the Helm documentation build, and the normal and special core test matrices. The overall fork run is still red because of integration setup failures: Kubernetes tests cannot find the expected base PROD image before exercising the chart, and PROD e2e tests fail during image-pull setup. These are not reported as passing integration tests. This is ready for another review. Could a maintainer approve the upstream Tests (AMD) and CodeQL runs so project CI can complete validation? Drafted-by: Codex (GPT-6) (no human review before posting) |
Replace the legacy
tier,component,release,chart, andheritagelabels for chart 2.0 with the Kubernetes-recommended application labels requested in #34048. Update resource and pod labels together with workload, Service, policy, and autoscaling selectors. Centralize label generation and normalization, preserve user-label precedence, and update the existing Helm tests, executor pod template, examples, and documentation.The review follow-up removes the separate label test module and news fragment, reverts unrelated resource-list changes, and includes the recommended name, instance, and version labels. This refresh rebases onto current
mainand reads the expected application version fromChart.yamlso version bumps do not leave hardcoded assertions behind.closes: #34048
Validation for this refresh:
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6) following the guidelines
Drafted-by: Codex (GPT-6) (no human review before posting)