Skip to content

Add Kubernetes-recommended labels to Helm chart - #71987

Open
mihirduvedi wants to merge 5 commits into
apache:mainfrom
mihirduvedi:feature-34048-kubernetes-labels
Open

mihirduvedi wants to merge 5 commits into
apache:mainfrom
mihirduvedi:feature-34048-kubernetes-labels

Conversation

@mihirduvedi

@mihirduvedi mihirduvedi commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Replace the legacy tier, component, release, chart, and heritage labels for chart 2.0 with the Kubernetes-recommended application labels requested in #34048. Update resource and pod labels together with workload, Service, policy, and autoscaling selectors. Centralize label generation and normalization, preserve user-label precedence, and update the existing Helm tests, executor pod template, examples, and documentation.

The review follow-up removes the separate label test module and news fragment, reverts unrelated resource-list changes, and includes the recommended name, instance, and version labels. This refresh rebases onto current main and reads the expected application version from Chart.yaml so version bumps do not leave hardcoded assertions behind.

closes: #34048

Validation for this refresh:

  • Regular and manual prek checks passed; the final commit's hooks passed, including kubeconform, mypy, Ruff, and formatting.
  • Helm lint passed. A rendered audit passed for 67 resources, 14 pod templates, 10 workload selectors, and 8 Service selectors with optional components enabled.
  • Full Helm tests passed: 2,280 tests across all nine groups with Kubernetes 1.31.12. Helm release checks, CI static checks, the Helm documentation build, and documentation publication/version validation also passed.
  • All normal database/non-database core jobs and the special core matrix passed. The broader fork run finished with 112 successful jobs, but is not fully green: Kubernetes/Kustomize integration jobs stop before exercising the chart because the expected base PROD image is missing locally; additional PROD e2e jobs fail during image-pull setup. These integration tests are not counted as passing.
  • Upstream Tests (AMD) and CodeQL require maintainer approval before they can run.

Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-5) for the original contribution; Codex (GPT-6) for this refresh.

Generated-by: Codex (GPT-6) following the guidelines


Drafted-by: Codex (GPT-6) (no human review before posting)

@Miretpl Miretpl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With using recommended k8s labels, we could delete old once (we are on chart 2.0 on main) and leave only necessery onces. We don't need to have all of these labels with duplicated values when there is Kubernetes standard for them.

Comment thread chart/tests/helm_tests/airflow_aux/test_recommended_labels.py Outdated
Comment thread chart/tests/helm_tests/airflow_aux/test_basic_helm_chart.py
Comment thread chart/templates/_helpers.yaml
Comment thread chart/newsfragments/71987.feature.rst Outdated
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 26, 2026
@mihirduvedi
mihirduvedi marked this pull request as draft October 26, 2026 20:07
@mihirduvedi
mihirduvedi force-pushed the feature-34048-kubernetes-labels branch from 8ba205c to 62a704e Compare October 26, 2026 20:07
@mihirduvedi
mihirduvedi marked this pull request as ready for review October 26, 2026 21:09
@mihirduvedi

mihirduvedi commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Refreshed this PR against current main and addressed the four review threads: removed the separate label test module and news fragment, reverted the unrelated test changes, and included the recommended name, instance, and version labels. The version assertions now read Chart.yaml rather than hardcoding the application version.

The fork CI run passed all 2,280 Helm tests across nine groups with Kubernetes 1.31.12, Helm release checks, static checks, the Helm documentation build, and the normal and special core test matrices.

The overall fork run is still red because of integration setup failures: Kubernetes tests cannot find the expected base PROD image before exercising the chart, and PROD e2e tests fail during image-pull setup. These are not reported as passing integration tests.

This is ready for another review. Could a maintainer approve the upstream Tests (AMD) and CodeQL runs so project CI can complete validation?


Drafted-by: Codex (GPT-6) (no human review before posting)

@github-actions github-actions Bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Kubernetes-recommended labels for airflow helm chart

2 participants