Skip to content

Remove redundant trait bounds on ArrowNativeTypeOp#9614

Merged
alamb merged 1 commit intoapache:mainfrom
alexandreyc:remove-redundant-trait-bounds
Apr 6, 2026
Merged

Remove redundant trait bounds on ArrowNativeTypeOp#9614
alamb merged 1 commit intoapache:mainfrom
alexandreyc:remove-redundant-trait-bounds

Conversation

@alexandreyc
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

None.

Rationale for this change

While reading the codebase I spotted some redundant trait bounds on ArrowNativeTypeOp.

What changes are included in this PR?

Remove some trait bounds on ArrowNativeTypeOp.

Are these changes tested?

It compiles so I guess it's enough.

Are there any user-facing changes?

Nope.

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Mar 24, 2026
@alexandreyc
Copy link
Copy Markdown
Contributor Author

Waiting for #9612 to be merged as it should fix the CI.

@alexandreyc alexandreyc force-pushed the remove-redundant-trait-bounds branch from 2c07228 to c134663 Compare March 25, 2026 10:02
@github-actions github-actions bot removed the parquet Changes to the parquet crate label Mar 25, 2026
@alexandreyc alexandreyc force-pushed the remove-redundant-trait-bounds branch from c134663 to 3a51cba Compare March 26, 2026 10:57
@alexandreyc
Copy link
Copy Markdown
Contributor Author

@alamb @tustvold Could you have a look? It's a simple and short one. Thanks!

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 1, 2026

@alamb @tustvold Could you have a look? It's a simple and short one. Thanks!

Sorry -- this was one o the PRs I felt was not simple to review (as I have to understand the implications of the boundary changes, specifically if there any downstream API breaking API changes)

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexandreyc -- I think this one looks good and will not cause issues with existing code that already compiles (as it effectively relaxes the trait requirements)

@alamb alamb merged commit fb58743 into apache:main Apr 6, 2026
26 checks passed
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 6, 2026

Thanks again @alexandreyc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants