Conversation
added 2 commits
December 22, 2025 11:21
This was missing and is blocking for release. Have to ad a specific workaround for template files (.tpl)
We exclude jsonl. examples is the symlink that it cannot handle So when you run rat, know the examples directory symlink will be a false negative
|
A preview of 472d6a3 is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/609 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
182ab9f to
2098608
Compare
2098608 to
db71fe9
Compare
added 2 commits
January 3, 2026 21:45
This is a convenience
skrawcz
reviewed
Jan 4, 2026
skrawcz
reviewed
Jan 4, 2026
skrawcz
reviewed
Jan 6, 2026
| Release artifacts are signed with your GPG key. The KEYS file is available at: | ||
| https://downloads.apache.org/incubator/{PROJECT_SHORT_NAME}/KEYS | ||
|
|
||
| Please download, verify, and test the release candidate. |
Contributor
There was a problem hiding this comment.
include instructions on what to do / how to verify.
skrawcz
reviewed
Jan 6, 2026
skrawcz
reviewed
Jan 6, 2026
scripts/README.md
Outdated
|
|
||
| ### Source tarball (`apache-burr-{version}-incubating.tar.gz`) | ||
| # Verify licenses (requires Apache RAT) | ||
| python scripts/verify_apache_artifacts.py licenses --rat-jar /path/to/apache-rat-0.15.jar |
Contributor
There was a problem hiding this comment.
where do we get the rat jar from?
skrawcz
reviewed
Jan 6, 2026
| @@ -0,0 +1,3 @@ | |||
| .*py\.typed | |||
Contributor
There was a problem hiding this comment.
probably want requirements.txt here too?
skrawcz
approved these changes
Jan 6, 2026
Contributor
skrawcz
left a comment
There was a problem hiding this comment.
need some more instructions in email, and where to get rat-jar from (maybe even cmd to get it?)
Contributor
|
need to update this PR too and have a commit message for code archaeology. |
9c29cc0 to
21f7684
Compare
21f7684 to
472d6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist