fix(persistence): improve error message for uninitialized SQLitePersister#613
Merged
skrawcz merged 2 commits intoapache:mainfrom Dec 31, 2025
Merged
Conversation
…ster When load(), save(), or list_app_ids() are called before initialize(), raise a clear RuntimeError with actionable guidance instead of cryptic sqlite3.OperationalError about missing table. Closes apache#417 Signed-off-by: majiayu000 <1835304752@qq.com>
skrawcz
requested changes
Dec 30, 2025
Contributor
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
Looks good -- just a small request.
burr/core/persistence.py
Outdated
Comment on lines
457
to
459
| f"Uninitialized persister: table '{self.table_name}' does not exist. " | ||
| f"Make sure to call .initialize() on the persister before passing it " | ||
| f"to the ApplicationBuilder." |
Contributor
There was a problem hiding this comment.
can you make this string a constant and use it in the other places please?
Address review feedback: extract the uninitialized persister error message to a module-level constant _UNINITIALIZED_PERSISTER_ERROR and use it in all three places (list_app_ids, load, save).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite3.OperationalErrorfor missing table and raises clearRuntimeErrorChanges
SQLitePersister.load(),save(), andlist_app_ids()Test plan
Closes #417