Skip to content

Imports modules in main electron process from cdv-electron-modules.json#135

Open
zorn-v wants to merge 1 commit into
apache:masterfrom
zorn-v:main-imports
Open

Imports modules in main electron process from cdv-electron-modules.json#135
zorn-v wants to merge 1 commit into
apache:masterfrom
zorn-v:main-imports

Conversation

@zorn-v
Copy link
Copy Markdown

@zorn-v zorn-v commented Jan 22, 2020

Motivation and Context

This allow inject modules by plugins in main electron process for making IPC channel for communication between main and renderrer processes for example.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #135   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         612    612           
=====================================
  Hits          612    612

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af81cc...e00c252. Read the comment docs.

@capc0
Copy link
Copy Markdown

capc0 commented Dec 16, 2020

@zorn-v do you have a working setup on how to inject other files into the main process with the current version right now? Or are you adjusting cdv-electron-main.js manually?

@zorn-v
Copy link
Copy Markdown
Author

zorn-v commented Dec 17, 2020

I'm just use remote.app from renderer process
https://github.com/zorn-v/cordova-plugin-file/blob/655b0c15b4352a6007d2cd4795e9a7344b512254/src/electron/FileProxy.js#L32-L35

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7af81cc) to head (e00c252).
⚠️ Report is 101 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          612       612           
=========================================
  Hits           612       612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants