Skip to content

Refactor away usage of NUMERICS/INTEGERS in datafusion/expr-common/src/type_coercion/aggregates.rs #18092

Description

@Jefffrey

pub static INTEGERS: &[DataType] = &[
DataType::Int8,
DataType::Int16,
DataType::Int32,
DataType::Int64,
DataType::UInt8,
DataType::UInt16,
DataType::UInt32,
DataType::UInt64,
];
pub static NUMERICS: &[DataType] = &[
DataType::Int8,
DataType::Int16,
DataType::Int32,
DataType::Int64,
DataType::UInt8,
DataType::UInt16,
DataType::UInt32,
DataType::UInt64,
DataType::Float32,
DataType::Float64,
];

Refactor these away in favour of using the TypeSignature API: https://github.com/apache/datafusion/blob/264030cca76d0bdb4d8809f252b422e72624a345/datafusion/expr-common/src/signature.rs

Need to take care for functions that will be affected, especially as for NUMERICS it doesn't contain Float16 or Decimals which TypeSignature::Numeric does include. Consider what changes might be necessary for downstream functions.

Activity

  1. self-assigned this
    on Oct 16, 2025
  2. theirix commented on Mar 20, 2026

    @theirix
    Contributor

    @Jefffrey, the last piece of this refactoring should be done via #21074

  3. removed their assignment
    on Apr 16, 2026
  4. added a commit that references this issue on Apr 18, 2026
    29f1acd
  5. added a commit that references this issue on Apr 21, 2026
    09deafb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions