You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make From<ConfigFileDecryptionProperties>/ConfigFileEncryptionProperties conversions fallible (TryFrom) #21974
Is your feature request related to a problem or challenge?
The conversions from ConfigFileDecryptionProperties to FileDecryptionProperties (and the matching encryption pair) currently use From, but the implementations contain several unwrap() and expect() calls. Bad input, for example a config value with an invalid hex string for the footer key, a column key, or the AAD prefix will panic instead of returning an error.
changed the title [-]Make From<ConfigFileDecryptionProperties>/ConfigFileEncryptionProperties conversions fallible (TryFrom)[/-][+]Make `From<ConfigFileDecryptionProperties>/ConfigFileEncryptionProperties` conversions fallible (TryFrom)[/+]on May 1, 2026
Activity
[-]Make From<ConfigFileDecryptionProperties>/ConfigFileEncryptionProperties conversions fallible (TryFrom)[/-][+]Make `From<ConfigFileDecryptionProperties>/ConfigFileEncryptionProperties` conversions fallible (TryFrom)[/+]kumarUjjawal commentedon May 1, 2026
@adamreeve would you be interested in picking this up?
Soham-Bhattacharjee-work commentedon May 1, 2026
take @kumarUjjawal
Soham-Bhattacharjee-work commentedon May 2, 2026
PR is up #21985. I would love to do any more changes if required @kumarUjjawal 😄
feat: Making From<ConfigFileDecryptionProperties/ConfigFileEncryption…