Repository navigation
Conversation
This is needed as an argument to `TopK::try_new()`, so without it it's impossible to construct a `TopK`.
masonh22
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 17, 2026
Upstream PR: apache#25429
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25429 +/- ##
==========================================
- Coverage 82.72% 82.71% -0.01%
==========================================
Files 1147 1147
Lines 448013 448013
Branches 448013 448013
==========================================
- Hits 370602 370596 -6
- Misses 54920 54923 +3
- Partials 22491 22494 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
masonh22
marked this pull request as ready for review
September 21, 2026 17:05
masonh22
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 21, 2026
Upstream PR: apache#25429
kosiew
approved these changes
Oct 6, 2026
| pub use crate::statistics::{ChildStats, StatisticsArgs, StatisticsContext}; | ||
| pub use crate::stream::EmptyRecordBatchStream; | ||
| pub use crate::topk::TopK; | ||
| pub use crate::topk::{TopK, TopKDynamicFilters}; |
Contributor
There was a problem hiding this comment.
Could you add a compiling rustdoc example or external integration test that imports both types from the crate root, constructs TopKDynamicFilters, and passes it to TopK::try_new? Tests inside the private topk module would still pass without this re-export, so a public-path compilation test would catch this visibility issue if it regresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
TopKDynamicFiltersis needed as an argument toTopK::try_new(), so without it it's impossible to construct aTopK.What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?