Repository navigation
fix: avoid query failures from inferred numeric cast bounds - #25528
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25528 +/- ##
========================================
Coverage 82.69% 82.70%
========================================
Files 1147 1147
Lines 447348 447535 +187
Branches 447348 447535 +187
========================================
+ Hits 369936 370118 +182
- Misses 54999 55005 +6
+ Partials 22413 22412 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
kosiew
approved these changes
Oct 3, 2026
kosiew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this. The change looks good to me. Numeric interval-bound casts now handle out-of-range inferred endpoints conservatively without changing runtime CAST and TRY_CAST behavior, and the added coverage exercises the relevant edge cases.
Contributor
Author
|
Thanks @kosiew |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #25524.
Related to #25407 and #22028.
Rationale for this change
A valid query can fail when an inferred numeric interval extends beyond the target CAST type, even though every runtime value fits. For example, an expression that always evaluates to zero can have an estimated upper bound of 1000 and fail when cast to TINYINT during planning.
What changes are included in this PR?
Use safe Arrow casts for numeric interval endpoints in
Interval::cast_to, independently of the runtime cast error policy. An endpoint that cannot be represented becomes unbounded, while a valid opposite endpoint is retained. Non-numeric conversions continue to honor the supplied cast options, and errors returned by the cast kernel are still propagated.What is the testing strategy for this PR?
cast.sltfor positive and negative inferred overflow, ordinary CAST runtime errors, and TRY_CAST runtime NULL results.Are there any user-facing changes?
Valid queries no longer fail solely because inferred numeric cast endpoints are out of range. Runtime CAST and TRY_CAST behavior is unchanged.