Repository navigation
Conversation
masonh22
force-pushed
the
agg-udf-accum-compat
branch
from
October 5, 2026 17:16
eb9fcb7 to
c3496a3
Compare
masonh22
force-pushed
the
agg-udf-accum-compat
branch
from
October 5, 2026 17:19
99ca719 to
560040a
Compare
masonh22
force-pushed
the
agg-udf-accum-compat
branch
from
October 5, 2026 17:40
6c850b7 to
52043c8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25710 +/- ##
==========================================
+ Coverage 82.66% 82.70% +0.03%
==========================================
Files 1147 1148 +1
Lines 446542 447811 +1269
Branches 446542 447811 +1269
==========================================
+ Hits 369154 370376 +1222
- Misses 54986 54999 +13
- Partials 22402 22436 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AggregateUDFImpl'sAccumulatorandGroupsAccumulator#25660.Rationale for this change
See #25660.
What changes are included in this PR?
This change adds:
datafusion_functions_aggregate::testing::check_state_compatibility(): A generic test that identifies cases where theAccumulatorandGroupsAccumulatorof anAggregateUDFdiffer. This is exposed as a public function that can be used to test this requirement onAggregateUDFImpls implemented by downstream consumers. The test is run on all built-in default aggregation functions.approx_distinct()andavg(), which both violated this requirementHLLAccumulatorused byapprox_distinct()to consume state produced byHllGroupsAccumulator#25659 to fixapprox_distinct()Accumulatorforavg()would return0for the count if it hasn't seen any non-null values. TheGroupsAccumulatorwould returnnullinstead. This change updates theAccumulators to also returnnullfor the count in this case.What is the testing strategy for this PR?
Are there any user-facing changes?