Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25854 +/- ##
==========================================
+ Coverage 82.51% 82.57% +0.05%
==========================================
Files 1141 1142 +1
Lines 439774 440946 +1172
Branches 439774 440946 +1172
==========================================
+ Hits 362896 364123 +1227
+ Misses 54939 54822 -117
- Partials 21939 22001 +62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zhuqi-lucas
approved these changes
Sep 30, 2026
Member
Author
|
Thanks @zhuqi-lucas |
xudong963
deleted the
xudong963/skip-bloom-on-fully-matched-row-groups
branch
September 30, 2026 06:35
martin-g
pushed a commit
to martin-g/datafusion
that referenced
this pull request
Sep 30, 2026
…25854) ## Which issue does this PR close? No linked issue. This is a follow-up to the fully matched Parquet row-group work in PR apache#23696. ## Rationale for this change When row-group statistics prove that every row satisfies a scan predicate, a Bloom filter cannot prune that group. Reading its Bloom filters still adds object-store I/O, which can be especially costly for remote files. ## What changes are included in this PR? - Skip Bloom filter reads and predicate evaluation for fully matched row groups. - Avoid creating a Bloom reader when every surviving row group is fully matched. - Keep the Bloom pruning matched metric accounting for skipped groups. ## What is the testing strategy for this PR? The new `fully_matched_row_groups_skip_bloom_filter_reads` test verifies that a partially matched group still reads Bloom filters, a fully matched group reduces `bytes_scanned`, and an all-fully-matched file reads zero Bloom bytes during open. It also checks that the returned rows are unchanged. ## Are there any user-facing changes? No API or query-result changes. Scans avoid unnecessary Bloom filter reads for fully matched row groups.
|
Thanks for this optimization. In if self.access_plan.is_fully_matched(idx) {
metrics.row_groups_pruned_bloom_filter.add_matched(1);
continue;
}This overlaps with #25822 (addressing #18355), which proposes counting only actual Bloom evaluation outcomes. I’ll incorporate this new path and extend the test to cover its metric accounting when updating that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No linked issue. This is a follow-up to the fully matched Parquet row-group work in PR #23696.
Rationale for this change
When row-group statistics prove that every row satisfies a scan predicate, a Bloom filter cannot prune that group. Reading its Bloom filters still adds object-store I/O, which can be especially costly for remote files.
What changes are included in this PR?
What is the testing strategy for this PR?
The new
fully_matched_row_groups_skip_bloom_filter_readstest verifies that a partially matched group still reads Bloom filters, a fully matched group reducesbytes_scanned, and an all-fully-matched file reads zero Bloom bytes during open. It also checks that the returned rows are unchanged.Are there any user-facing changes?
No API or query-result changes. Scans avoid unnecessary Bloom filter reads for fully matched row groups.