Repository navigation
bench: Add regexp pattern reuse benchmarks - #26046
AnthonyZhOon wants to merge 1 commit into
Conversation
|
run benchmark regex_expressions |
|
Hi @AnthonyZhOon, thanks for the request (#26046 (comment)). Only whitelisted users can trigger benchmarks. Allowed users: 2010YOUY01, Dandandan, Fokko, HippoBaro, Jefffrey, Omega359, Rachelint, Rich-T-kid, adriangb, alamb, asubiotto, avantgardnerio, brunal, buraksenn, cetra3, codephage2020, coderfender, comphead, erenavsarogullari, etseidl, friendlymatthew, gabotechs, geoffreyclaude, grtlr, haohuaijin, jayzhan211, jonathanc-n, kevinjqliu, klion26, kosiew, kumarUjjawal, kunalsinghdadhwal, liamzwbao, mbutrovich, mkleen, mzabaluev, neilconway, rluvaton, sdf-jkl, timsaucer, xudong963, zhuqi-lucas. File an issue against this benchmark runner |
|
run benchmark regex_expressions |
|
Thanks @AnthonyZhOon I started the benchmarks Have you run any end to end tests (like with datafusion-cli) where you can measure the impact of this change? |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing codex/regexp-benchmarks (003775e) to b550f59 (merge-base) diff Run configurationrun benchmark regex_expressionsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing codex/regexp-benchmarks (003775e) to b550f59 (merge-base) diff Run configurationrun benchmark regex_expressionsCPU Details (lscpu)Details
Resource Usageregex_expressions — base (merge-base)
regex_expressions — branch
File an issue against this benchmark runner |
|
@alamb SELECT SUM(regexp_count(
"URL",
CASE WHEN "SearchEngineID" = 0
THEN '[?&](from|utm_[^=&#]+)='
ELSE '[?&](q|query|text|search)='
END
)) AS parameter_matches
FROM hits; |
Which issue does this PR close?
Rationale for this change
The issue is about adding regex caching to improve throughput for the regexp functions, this PR separates out the benchmarks to run before and after adding the cache.
What changes are included in this PR?
The benchmarks for cached regexp functions are added
What is the testing strategy for this PR?
Only benchmarks are added, no functional code to be tested
Are there any user-facing changes?
No