Repository navigation
test: generate NULLs in equivalence fuzz tests - #26086
Open
Nagato-Yuzuru wants to merge 4 commits into
Open
Nagato-Yuzuru wants to merge 4 commits into
Nagato-Yuzuru wants to merge 4 commits into
Conversation
…guration and support random sort options
Refactor fuzz tests to replace `contains_overflowable_arithmetic` with `contains_conservative_ordering_op`, extending operator handling to include comparisons, logical operators, and arithmetic. Add new test cases for conservative operator logic verification.
8 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26086 +/- ##
==========================================
+ Coverage 82.42% 82.72% +0.29%
==========================================
Files 1139 1147 +8
Lines 435357 448179 +12822
Branches 435357 448179 +12822
==========================================
+ Hits 358844 370740 +11896
- Misses 54812 54902 +90
- Partials 21701 22537 +836 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #24243
Rationale for this change
The equivalence fuzz tests never generated NULLs. So they could not catch NULL-ordering bugs in
SortPropertiespropagation such as #11596 and #24208.What changes are included in this PR?
NULL_PCTS = [0.0, 0.1, 0.5]), crossed with every seed; the schema is nullable only when the rate is non-zero.create_random_schemapicks randomSortOptionsfor each ordering key.SortOptionsare checked only for soundness: ifordering_satisfyaccepts an ordering, the data must be sorted by it. The converse is not checked, since one batch can be sorted by coincidence (e.g. NULLs of independent columns landing in the same rows). For the same reason,contains_overflowable_arithmeticis renamed tocontains_conservative_ordering_opand also covers comparisons andAND/OR.What is the testing strategy for this PR?
Test-only change. Verified locally that reverting the fixes from #24276 and #24206 makes
test_ordering_satisfy_with_equivalence_complex_randomfail, and that it passes on main:Are there any user-facing changes?
No