Repository navigation
Conversation
… plan information when debug is enabled. This is preliminary work prior to adding sort_pushdown benchmarks to sql benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #26212; this branch includes its plan-diagnostics commits.
Which issue does this PR close?
Rationale for this change
Add the existing sort pushdown workloads to the SQL benchmark runner as a standalone suite.
What changes are included in this PR?
Add 30 cases across
baseline,sorted,inexact,inexact_unsorted, andinexact_overlap, with suite metadata, table registration SQL, and usage documentation. The cases reference the existing query files and reuse the existing Parquet datasets.The suite preserves the legacy ordering declarations, statistics collection, and inexact filter-pushdown settings. Data generation remains in the unchanged
bench.sh; the legacy benchmark remains available. The known result-validation ordering issue is outside this change.What is the testing strategy for this PR?
Compared the SQL and legacy runners on the same datasets using two rounds of five iterations per case, reversing runner order for the second round (600 timed executions). All row counts matched.
The sums of per-case median times differed by -0.6%, -0.1%, +4.4%, -3.9%, and -6.6% across the five subgroups, respectively. Focused rechecks resolved two timing outliers; sorted query 2 remained about 16% faster in the SQL runner at roughly 2 ms.
A separate verifier found matching physical plans for all 30 cases and correctly ordered outputs. Full-row fingerprints matched in 29 cases; overlap query 3 differed only in permitted ties at the LIMIT boundary. Original base-data checksums were unchanged.
Release builds, documentation formatting, and
git diff --checkpassed.Are there any user-facing changes?
The standalone suite is available from
benchmarks/with:Use
--subgroupand--queryto select a variant and original query number.