Skip to content

Allow to run ds-memory 3.0 on Java 25#271

Closed
pan3793 wants to merge 2 commits intoapache:3.0.Xfrom
pan3793:3.0-java25
Closed

Allow to run ds-memory 3.0 on Java 25#271
pan3793 wants to merge 2 commits intoapache:3.0.Xfrom
pan3793:3.0-java25

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 31, 2026

This PR relaxes runtime Java version check - add Java 25 to the allow list, for datasketches-memory 3.0.

I understand that Java 17/21/25 is not supported by datasketches-memory 3.0.2, but I'd like to run it in limited mode with Java 25, as it does on Java 17/21.

Verification:

Have done somke test with Apache Spark, see details at #270 (comment)

I can run integration tests with Spark if datasketches-memory can have a SNAPSHOT or RC release (includes this patch) available on a public Maven repo


UPDATE:

I have made this change and deployed to our internal Maven repo, and integrated with internal Spark, I confirm all Spark cases work well with Java 25, so I think datasketches-memory 3.0 can work well in limited mode on Java 25, as it does on Java 17/21.

@pan3793
Copy link
Member Author

pan3793 commented Feb 3, 2026

@leerho, could you please take a look? thank you in advance.

@leerho
Copy link
Member

leerho commented Feb 4, 2026

@pan3793,
I have been thinking about your request and looked at your code and found a few more things that needed to be fixed. So instead of this PR, I have submitted a different PR #272, that adds a warning so that users attempting to run this code with Java versions > 11 will get a warning that no off-heap operations can be used. As you can see, if you look at 272, I found a bunch of checkstyle warnings that needed to be fixed as well.

Since 272 supersedes this one, I will close this one.

Thank you for your suggestions on this. Please thoroughly test the new prepare_3.0.3 branch form 272 in your environment to make sure it works with 25 like you expect. Do not expect it to pass tests with Java versions > 11.

@leerho leerho closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants