You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR relaxes runtime Java version check - add Java 25 to the allow list, for datasketches-memory 3.0.
I understand that Java 17/21/25 is not supported by datasketches-memory 3.0.2, but I'd like to run it in limited mode with Java 25, as it does on Java 17/21.
Verification:
Have done somke test with Apache Spark, see details at #270 (comment)
I can run integration tests with Spark if datasketches-memory can have a SNAPSHOT or RC release (includes this patch) available on a public Maven repo
UPDATE:
I have made this change and deployed to our internal Maven repo, and integrated with internal Spark, I confirm all Spark cases work well with Java 25, so I think datasketches-memory 3.0 can work well in limited mode on Java 25, as it does on Java 17/21.
@pan3793,
I have been thinking about your request and looked at your code and found a few more things that needed to be fixed. So instead of this PR, I have submitted a different PR #272, that adds a warning so that users attempting to run this code with Java versions > 11 will get a warning that no off-heap operations can be used. As you can see, if you look at 272, I found a bunch of checkstyle warnings that needed to be fixed as well.
Since 272 supersedes this one, I will close this one.
Thank you for your suggestions on this. Please thoroughly test the new prepare_3.0.3 branch form 272 in your environment to make sure it works with 25 like you expect. Do not expect it to pass tests with Java versions > 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relaxes runtime Java version check - add Java 25 to the allow list, for
datasketches-memory3.0.I understand that Java 17/21/25 is not supported by datasketches-memory 3.0.2, but I'd like to run it in limited mode with Java 25, as it does on Java 17/21.
Verification:
Have done somke test with Apache Spark, see details at #270 (comment)
I can run integration tests with Spark if
datasketches-memorycan have a SNAPSHOT or RC release (includes this patch) available on a public Maven repoUPDATE:
I have made this change and deployed to our internal Maven repo, and integrated with internal Spark, I confirm all Spark cases work well with Java 25, so I think
datasketches-memory3.0 can work well in limited mode on Java 25, as it does on Java 17/21.