C++ integration test by leekeiabstraction · Pull Request #352 · apache/fluss-rust

leekeiabstraction · 2026-02-18T19:53:11Z

Purpose

Linked issue: close #338

Brief change log

Add C++ client integration tests
Update CI to trigger CI test more selectively

leekeiabstraction · 2026-02-18T19:53:32Z

@fresh-borzoni Appreciate your review here 🙏

fresh-borzoni · 2026-02-18T20:26:48Z

@leekeiabstraction, it might be the case that we would need to get #351 merged first
I changes some C++ API to match between clients:

Size() to Count() on ScanRecord, it matches Java/Rust
Empty() to isEmpty() on ScanRecords, it matches Java/Rust
we still support flat iteration: for (const auto& rec : scan_records) , but not indexing as it isn't exposed in Java/Rust, so I removed it, still exposed it in Python as it's more pythonic, but it's debatable

leekeiabstraction · 2026-02-18T20:28:11Z

That is fine. We can update this afterwards

leekeiabstraction · 2026-02-18T20:31:29Z

Still appreciate your early review on the other parts within this PR though! 🙏🏼

fresh-borzoni

@leekeiabstraction Ty for the PR.

quickly looked through. Left couple of comments, but still 'review in progress'
PTAL

bindings/cpp/test/test_utils.h

fresh-borzoni · 2026-02-18T21:09:19Z

bindings/cpp/test/test_utils.h

+inline std::vector<fluss::ScanRecord> PollRecords(fluss::LogScanner& scanner,
+                                                   size_t expected_count,
+                                                   int timeout_seconds = 10) {
+    // We need to keep the ScanRecords alive since ScanRecord borrows from them


we shall remove it as it just returns empty vector in the end.
But it actually made me think - mb we should just use shared_ptr and I overcomplicated this pattern, it basically would be Arc from Rust.

prepared the fix for this: seems to work and better overall: #353

Thanks, will update the test to use the latest APIs once #331 is also merged

#331 is merged, so we can rework this to reduce boilerplate with poll with deadline pattern

bindings/cpp/test/test_utils.h

fresh-borzoni

@leekeiabstraction finished review, left comments. PTAL

also once scan by buckets PR is merged - we need to add some tests for it

bindings/cpp/test/test_kv_table.cpp

bindings/cpp/test/test_log_table.cpp

luoyuxia · 2026-02-20T16:03:35Z

@leekeiabstraction Hi, since #331 is merge, maybe you need to update the pr

… Cpp IT

leekeiabstraction · 2026-02-20T20:12:12Z

@fresh-borzoni Updated C++ IT to also use per-bucket scan records view. Appreciate if you can have a look. TY.

fresh-borzoni

@leekeiabstraction Ty, left some comments. PTAL

fresh-borzoni · 2026-02-20T21:33:30Z

bindings/cpp/test/test_utils.h

+inline std::vector<fluss::ScanRecord> PollRecords(fluss::LogScanner& scanner,
+                                                   size_t expected_count,
+                                                   int timeout_seconds = 10) {
+    // We need to keep the ScanRecords alive since ScanRecord borrows from them


#331 is merged, so we can rework this to reduce boilerplate with poll with deadline pattern

bindings/cpp/test/test_utils.h

…ds) for rust

leekeiabstraction · 2026-02-21T12:46:12Z

Thank you for the review @fresh-borzoni , updated, PTAL

fresh-borzoni

@leekeiabstraction Ty, LGTM!

Copilot

Pull request overview

This PR adds comprehensive C++ integration tests for the Fluss client library and refactors the CI workflow structure to be more modular and efficient.

Changes:

Added complete C++ integration test suite covering Admin API, log tables, and KV tables
Restructured CI workflows into separate, language-specific jobs with intelligent path-based triggering
Updated Rust and Python tests to consistently use distributed tables with explicit bucket configuration

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
bindings/cpp/test/test_utils.h	Test infrastructure with Docker-based Fluss cluster management, GoogleTest environment setup, and utility functions for polling and assertions
bindings/cpp/test/test_main.cpp	GoogleTest entry point that registers the global Fluss test environment
bindings/cpp/test/test_admin.cpp	Integration tests for Admin API operations including database/table creation, partition management, and error handling
bindings/cpp/test/test_log_table.cpp	Comprehensive log table tests covering append/scan, offsets, projections, batches, data types, and partitioning
bindings/cpp/test/test_kv_table.cpp	KV table tests for upsert/delete/lookup, composite primary keys, partial updates, partitioning, and data types
bindings/cpp/CMakeLists.txt	CMake configuration additions for building and running GoogleTest-based integration tests
.github/workflows/ci.yml	Removed monolithic CI workflow in favor of separate specialized workflows
.github/workflows/check_license_and_formatting.yml	New workflow dedicated to license header and code formatting checks
.github/workflows/build_and_test_rust.yml	Rust-specific build and test workflow with path-based triggering to skip on binding-only changes
.github/workflows/build_and_test_python.yml	Python-specific build and test workflow that skips on C++ binding changes
.github/workflows/build_and_test_cpp.yml	C++ build and test workflow with Arrow dependency installation and test execution
.github/workflows/check_documentation.yml	Minor workflow name update for consistency
crates/fluss/tests/integration/log_table.rs	Updated to use explicit bucket distribution configuration (3 buckets distributed by "c1")
bindings/python/test/test_log_table.py	Updated Python tests to match the distributed table configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bindings/cpp/test/test_utils.h

.github/workflows/check_license_and_formatting.yml

luoyuxia

@leekeiabstraction Thanks. +1

leekeiabstraction force-pushed the cpp-integration-test branch 2 times, most recently from 21bab65 to 93a758f Compare February 18, 2026 20:19

fresh-borzoni reviewed Feb 18, 2026

View reviewed changes

fresh-borzoni reviewed Feb 19, 2026

View reviewed changes

bindings/cpp/test/test_kv_table.cpp Show resolved Hide resolved

bindings/cpp/test/test_log_table.cpp Show resolved Hide resolved

leekeiabstraction added 3 commits February 20, 2026 19:59

C++ integration test

2b0e2cd

Add additional buckets for log table IT. Add partialUpdateByIndex for…

74ff366

… Cpp IT

Add C++ per-bucket scan integration test

6b842b6

leekeiabstraction force-pushed the cpp-integration-test branch from 8f82bd4 to 6b842b6 Compare February 20, 2026 20:10

fresh-borzoni reviewed Feb 20, 2026

View reviewed changes

leekeiabstraction added 5 commits February 21, 2026 09:45

Remove unused utils methods

8fc0bed

Remove unnecessary python versions run on rust only CI

94563cb

Remove unnecessary separate build job (integration test job also buil…

ce628df

…ds) for rust

Consistent CI File and Job namings

c090ec5

Reduce boilerplate for polling in C++ IT

bdb8a28

fresh-borzoni approved these changes Feb 21, 2026

View reviewed changes

luoyuxia requested a review from Copilot February 22, 2026 02:46

Copilot started reviewing on behalf of luoyuxia February 22, 2026 02:46 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

bindings/cpp/test/test_utils.h Show resolved Hide resolved

.github/workflows/check_license_and_formatting.yml Show resolved Hide resolved

luoyuxia approved these changes Feb 22, 2026

View reviewed changes

luoyuxia merged commit f39d68c into apache:main Feb 22, 2026
12 checks passed

Conversation

leekeiabstraction commented Feb 18, 2026

Purpose

Brief change log

Uh oh!

leekeiabstraction commented Feb 18, 2026

Uh oh!

fresh-borzoni commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leekeiabstraction commented Feb 18, 2026

Uh oh!

leekeiabstraction commented Feb 18, 2026

Uh oh!

fresh-borzoni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fresh-borzoni Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

leekeiabstraction Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

fresh-borzoni Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fresh-borzoni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

luoyuxia commented Feb 20, 2026

Uh oh!

leekeiabstraction commented Feb 20, 2026

Uh oh!

fresh-borzoni left a comment

Choose a reason for hiding this comment

Uh oh!

fresh-borzoni Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

leekeiabstraction commented Feb 21, 2026

Uh oh!

fresh-borzoni left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

luoyuxia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fresh-borzoni commented Feb 18, 2026 •

edited

Loading