feat(iceberg): add IcebergBinaryRowWriter#366
Open
charlesdong1991 wants to merge 4 commits intoapache:mainfrom
Open
feat(iceberg): add IcebergBinaryRowWriter#366charlesdong1991 wants to merge 4 commits intoapache:mainfrom
charlesdong1991 wants to merge 4 commits intoapache:mainfrom
Conversation
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR, left some comments.
| /// | ||
| /// [`CompactedRowWriter`]: crate::row::compacted::CompactedRowWriter | ||
| /// [`IcebergBucketingFunction`]: crate::bucketing::IcebergBucketingFunction | ||
| pub struct IcebergBinaryRowWriter { |
Contributor
There was a problem hiding this comment.
Should this PR also contain IcebergKeyEncoder? IcebergKeyEncoder implementation should be small, but the test cases there should provide a lot of value in verifying correctness of IcebergBinaryRowWriter.
See CompactedKeyEncoder implementation and test as example.
Contributor
Author
There was a problem hiding this comment.
Actually, similar to previous comment, I notice IcebergKeyEncoder is being worked on in #308 .
So I can have a TODO to verify and add tests (since that key encoder is sort of consumer of row writer) after that PR is merged?
Contributor
Author
There was a problem hiding this comment.
i added a TODO comment in the function, and will address after 308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements IcebergBinaryRowWriter, efforts as part of #194
Tests
All tests are passed locally