[client] Added Description getter method for DataField#418
Open
niknegi wants to merge 1 commit intoapache:mainfrom
Open
[client] Added Description getter method for DataField#418niknegi wants to merge 1 commit intoapache:mainfrom
niknegi wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
Overall LGTM, left a minor comment
Comment on lines
+1496
to
+1498
| let desc = field_with_desc.description(); | ||
| assert!(desc.is_some()); | ||
| assert_eq!(desc.unwrap(), "Unique identifier for the user"); |
Contributor
There was a problem hiding this comment.
i think tests here a bit redundant and re-verifies what the first assert_eq already did
Contributor
Author
There was a problem hiding this comment.
Updated this, kept the unwrap assert to check if the actual description string matches what was originally passed
fresh-borzoni
approved these changes
Mar 7, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@niknegi TY for the PR, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #328