feat: add equals_with_field_id method for RowType (#327)#428
Open
niknegi wants to merge 1 commit intoapache:mainfrom
Open
feat: add equals_with_field_id method for RowType (#327)#428niknegi wants to merge 1 commit intoapache:mainfrom
niknegi wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@niknegi Ty for the PR, left comments, PTAL
| pub name: String, | ||
| pub data_type: DataType, | ||
| pub description: Option<String>, | ||
| pub field_id: i32, |
Contributor
There was a problem hiding this comment.
Derived PartialEq/Hash now includes field_id, Java explicitly excludes it. This silently breaks equality
| &self.data_type | ||
| } | ||
|
|
||
| pub fn field_id(&self) -> i32 { |
Contributor
There was a problem hiding this comment.
this needs full wiring, JSON serde doesn't read/write field_id yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented equals_with_field_id using the java client as reference
Linked issue:
#327