Skip to content

mod_http2: Send HTTP/2 error codes in GOAWAY frames - #799

Open
arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-70212-h2-goaway-error-code
Open

arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-70212-h2-goaway-error-code

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

h2_session_shutdown() passed its reason, an APR or nghttp2 status, as the error code of the GOAWAY frame. A connection timeout was sent as 70007 (APR_TIMEUP), an inadequate TLS connection as 22 (APR_EINVAL).

Give h2_session_shutdown() the HTTP/2 error code as a separate argument. Timeouts and graceful shutdowns send NO_ERROR, failures INTERNAL_ERROR and inadequate TLS parameters INADEQUATE_SECURITY.

PR: 70212

h2_session_shutdown() passed its reason, an APR or nghttp2 status, as the
error code of the GOAWAY frame. A connection timeout was sent as 70007
(APR_TIMEUP), an inadequate TLS connection as 22 (APR_EINVAL).

Give h2_session_shutdown() the HTTP/2 error code as a separate argument.
Timeouts and graceful shutdowns send NO_ERROR, failures INTERNAL_ERROR
and inadequate TLS parameters INADEQUATE_SECURITY.

PR: 70212
@arturobernalg
arturobernalg force-pushed the fix/httpd-70212-h2-goaway-error-code branch from 8d9c213 to db1ac93 Compare October 8, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant