Repository navigation
core: Fix ap_varbuf_regsub() crash on an empty result - #806
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
* server/util.c (regsub_core): Do not terminate the result when nothing is added and the varbuf has no buffer yet; vb->buf is then the shared read-only empty string. This crashed mod_substitute when a regular expression rule replaced a whole line with an empty string. * test/modules/filters/test_004_substitute_empty.py: New test. PR: 70012
arturobernalg
force-pushed
the
fix/httpd-70012-substitute-empty-replacement
branch
from
October 8, 2026 17:28
49f9d1b to
5c82109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server/util.c (regsub_core): Do not terminate the result when nothing is added and the varbuf has no buffer yet; vb->buf is then the shared read-only empty string. This crashed mod_substitute when a regular expression rule replaced a whole line with an empty string.
test/modules/filters/test_004_substitute_empty.py: New test.
PR: 70012