Skip to content

mod_sed: Fix the new tests on Windows, add CHANGES entry - #818

Closed
notroj wants to merge 1 commit into
apache:trunkfrom
notroj:mod_sed-windows
Closed

notroj wants to merge 1 commit into
apache:trunkfrom
notroj:mod_sed-windows

Conversation

@notroj

@notroj notroj commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #791.

The mod_sed tests that expect a configuration to be rejected read env.apachectl_stderr, which is not set on Windows, so they fail there. TestSed.configure(fails=True) now runs httpd -t itself and returns its stderr. This also adds changes-entries/sed-fixes.txt for the #791 fixes.

🤖 Generated with Claude Code

  failing configuration with httpd -t, and return its stderr;
  apachectl_stderr is not set on Windows.
  (test_filters_003_32, test_filters_003_35, test_filters_003_38,
  test_filters_003_39, test_filters_003_40, test_filters_003_42,
  test_filters_003_44, test_filters_003_45, test_filters_003_46): Use it.

* changes-entries/sed-fixes.txt: Add entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@notroj

notroj commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

Merged in 1d27502 somehow the git mirror was stale.

@notroj notroj closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant