Repository navigation
mod_allowmethods: Populate Allow for denied methods - #823
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
Publish the configured methods through allowed_methods when AllowMethods rejects a request, so 405 responses contain the methods actually supported by the resource.
Member
Author
|
I found an important limitation with the current approach. For example, with AllowMethods GET PATCH on a static resource, a denied PUT would advertise PATCH in Allow, even though a PATCH request is rejected by the default handler. AllowMethods describes an access policy, while Allow is supposed to describe methods supported by the target resource. At the point where mod_allowmethods rejects the request, httpd has no generic mechanism to query the selected handler's supported methods. So the current implementation cannot produce an exact Allow value in all cases without broader handler-capability support. I am leaving the PR open for feedback before changing the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish the configured methods through allowed_methods when AllowMethods rejects a request, so 405 responses contain the methods actually supported by the resource.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.